-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove edge_width for points layer #167
Conversation
Thanks for writing here! Yeah, it changed name to |
Sure, I can update it! |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Clashes with the napari version in the tests it seems :/ |
Right, this will fail with anything below Line 49 in bf6f537
except it should pass a different key depending on the version! |
I understand. Is it the exact same version (0.5.0a) as for the projection mode? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 42.00% 42.00%
=======================================
Files 10 10
Lines 500 500
=======================================
Hits 210 210
Misses 290 290 ☔ View full report in Codecov by Sentry. |
Thanks, looks good! :) |
Great! |
While trying the nightly build I got the following bug when trying to open blik:
The traceback suggested that edge_width is not an available keyword for the points layer in napari (I guess changed in latest napari?), so I made a fork and removed it. This fixes the issue for me and therefore made a pr in case you want to merge it.
I didn't look into what changed in Napari or whether the option is fully removed or changed name.